Fix default value for hash_collision in EVMState
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`false` is a `Bool`. The intended default value. `False` is the `Prop` representing a contradiction, not the intended default value of `hash_collision`, but since `False` is a decidable proposition, Lean automatically treats this as `decide False` which is a `Bool`. Although we can actually prove `false = False` in Lean, using `false` directly is preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the default value for
hash_collisionas defined inEVMState.leanfalseis aBool. The intended default value.Falseis theProprepresenting a contradiction, not the intended default value ofhash_collision, but sinceFalseis a decidable proposition, Lean automatically treats this asdecide Falsewhich is aBool. Although we can actually provefalse = Falsein Lean, usingfalsedirectly is preferable.The way this is handled in Lean leads to the following:
theorem false_eq_false : false = false := by rfl -- succeeds (of course)theorem false_eq_False₁ : false = False := by rfl -- failstheorem false_eq_False₂ : false = False := by simp -- succeedsThis has implications when doing proofs relating to the default value for
hash_collision, such as here:Clear/Generated/erc20shim/ERC20Shim/fun_allowance_user.lean
Line 400 in 4bd6a34
hash_collisionback toFalsethere causeslake build +Generated.erc20shim.ERC20Shim.fun_allowance_userto fail. We could work around this in the proof, but it seems better to fixEVMState.leaninstead.